Re: [PATCH 1/3] xfs: simplify extent allocation alignment

John Garry
2024-04-02T15:11:33Z

On 02/04/2024 08:49, John Garry wrote:
> Update:
> So I have some more patches from trying to support both truncate and
> fallocate + punch/insert/collapse for forcealign.
>
> I seem to have at least 2x problems:
> - unexpected -ENOSPC in some case

This -ENOSPC seems related to xfs_bmap_select_minlen() again.

I find that it occurs when calling xfs_bmap_select_minlen() and blen ==
maxlen again, like:
blen=64 args->alignment=16, minlen=0, maxlen=64

And then this gives:
args->minlen=48 blen=64

But xfs_alloc_vextent_start_ag() -> xfs_alloc_vextent_iterate_ags() does
not seem to find something suitable.

I'm continuing to look...