Re: [PATCH v13.2.1 26/31] xfs: add parent pointer ioctls

Christoph Hellwig
2024-04-18T04:21:17Z

On Wed, Apr 17, 2024 at 03:25:03PM -0700, Darrick J. Wong wrote:
> > + /* parent pointer ioctls */
> > + XFS_CHECK_STRUCT_SIZE(struct xfs_getparents_rec, 32);
>
> It turns out that the i386 (or probably just 32-bit) build robots trip
> over this statement, probably because of the implied padding after the
> gpr_name[] flexarray. I'll change this to:
>
> XFS_CHECK_OFFSET(struct xfs_getparents_rec, gpr_name, 26);
>
> and let's see what they say. armhf checks out locally.

Please make the padding explicit and keep the
XFS_CHECK_STRUCT_SIZE, otherwise the ioctl won't work for 32-bit
i386 binaries on an x86_64 kernel.