public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <bodonnel@redhat.com>
To: Andrey Albershteyn <aalbersh@redhat.com>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 0/4] xfsprogs random fixes found by Coverity scan
Date: Tue, 16 Apr 2024 15:51:30 -0500	[thread overview]
Message-ID: <Zh7k0u7CqyNx3y8W@redhat.com> (raw)
In-Reply-To: <20240416202402.724492-1-aalbersh@redhat.com>

On Tue, Apr 16, 2024 at 10:23:58PM +0200, Andrey Albershteyn wrote:
> This is bunch of random fixes found by Coverity scan, there's memory
> leak, truncation of time_t to int, access overflow, and freeing of
> uninitialized struct.
> 
> --
> Andrey

Could you add a brief change history on patch 0/4 for v2?
Besides that, the series looks fine to me and you can add:
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>

> 
> Andrey Albershteyn (4):
>   xfs_db: fix leak in flist_find_ftyp()
>   xfs_repair: make duration take time_t
>   xfs_scrub: don't call phase_end if phase_rusage was not initialized
>   xfs_fsr: convert fsrallfs to use time_t instead of int
> 
>  db/flist.c          | 4 +++-
>  fsr/xfs_fsr.c       | 8 ++++++--
>  repair/globals.c    | 2 +-
>  repair/globals.h    | 2 +-
>  repair/progress.c   | 7 ++++---
>  repair/progress.h   | 2 +-
>  repair/xfs_repair.c | 2 +-
>  scrub/xfs_scrub.c   | 3 ++-
>  8 files changed, 19 insertions(+), 11 deletions(-)
> 
> -- 
> 2.42.0
> 
> 


      parent reply	other threads:[~2024-04-16 20:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 20:23 [PATCH v2 0/4] xfsprogs random fixes found by Coverity scan Andrey Albershteyn
2024-04-16 20:23 ` [PATCH v2 1/4] xfs_db: fix leak in flist_find_ftyp() Andrey Albershteyn
2024-04-16 20:24 ` [PATCH v2 2/4] xfs_repair: make duration take time_t Andrey Albershteyn
2024-04-16 21:00   ` Darrick J. Wong
2024-04-16 20:24 ` [PATCH v2 3/4] xfs_scrub: don't call phase_end if phase_rusage was not initialized Andrey Albershteyn
2024-04-16 20:24 ` [PATCH v2 4/4] xfs_fsr: convert fsrallfs to use time_t instead of int Andrey Albershteyn
2024-04-16 20:59   ` Darrick J. Wong
2024-04-16 20:51 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zh7k0u7CqyNx3y8W@redhat.com \
    --to=bodonnel@redhat.com \
    --cc=aalbersh@redhat.com \
    --cc=cem@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox