Re: [PATCH 23/32] xfs: Filter XFS_ATTR_PARENT for getfattr

Christoph Hellwig
2024-04-11T03:29:39Z

On Wed, Apr 10, 2024 at 02:58:27PM -0700, Darrick J. Wong wrote:
> "xfs: don't return XFS_ATTR_PARENT attributes via listxattr
>
> "Parent pointers are internal filesystem metadata. They're not intended
> to be directly visible to userspace, so filter them out of
> xfs_xattr_put_listent so that they don't appear in listxattr."

Looks good.

> > However I'd make it part of the top of file comment above the include
> > statements. And please add it in a separate commit as it has nothing
> > to do with the other changes here.
>
> Or just get rid of the comment entirely? It came from the verity
> series.

Fine with me.