Re: [PATCH 3/4] xfs: rename xfs_da_args.attr_flags

Darrick J. Wong
2024-04-11T04:15:27Z

On Wed, Apr 10, 2024 at 08:26:46PM -0700, Christoph Hellwig wrote:
> On Wed, Apr 10, 2024 at 01:55:28PM -0700, Darrick J. Wong wrote:
> > On Tue, Apr 09, 2024 at 10:01:55PM -0700, Christoph Hellwig wrote:
> > > On Tue, Apr 09, 2024 at 05:50:07PM -0700, Darrick J. Wong wrote:
> > > > From: Darrick J. Wong <djwong@kernel.org>
> > > >
> > > > This field only ever contains XATTR_{CREATE,REPLACE}, so let's change
> > > > the name of the field to make the field and its values consistent.
> > >
> > > So, these flags only get passed to xfs_attr_set through xfs_attr_change
> > > and xfs_attr_setname, which means we should probably just pass them
> > > directly as in my patch (against your whole stack) below.
> >
> > Want me to reflow this through the tree, or just tack it on the end
> > after (perhaps?) "xfs: fix corruptions in the directory tree" ?
>
> If it makes your life easier feel free to add it at the end.

It does, and done!

--D