Re: [PATCH 01/14] xfs: add xattr setname and removename functions for internal users

Christoph Hellwig
2024-04-11T04:50:24Z

On Wed, Apr 10, 2024 at 09:30:48PM -0700, Darrick J. Wong wrote:
> Heh, I almost did that:
>
> enum xfs_attr_change {
> XAC_CREATE = XATTR_CREATE,
> XAC_REPLACE = XATTR_REPLACE,
> XAC_UPSERT,
> XAC_REMOVE,
> };
>
> (500 patches from now when I get around to removing xattr_flags & making
> it a parameter.)

Heh. Reusing the XATTR_* values is ok, but I doubt it's really worth
the effort given that just one caller actually uses them.