[PATCH 08/32] xfs: allow logged xattr operations if parent pointers are enabled

Darrick J. Wong
2024-04-10T00:55:36Z

From: Darrick J. Wong <djwong@kernel.org>

Don't trip this assertion about attr log items if we have parent
pointers enabled. Parent pointers are an incompat feature that doesn't
use any of the functionality protected by
XFS_SB_FEAT_INCOMPAT_LOG_XATTRS, which is why this is ok.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/xfs_attr_item.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index 8f91016fc3cf8..c509bf841949f 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -474,7 +474,7 @@ xfs_attri_validate(
{
unsigned int op = xfs_attr_log_item_op(attrp);

- if (!xfs_is_using_logged_xattrs(mp))
+ if (!xfs_is_using_logged_xattrs(mp) && !xfs_has_parent(mp))
return false;

if (attrp->__pad != 0)