From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
chandan.babu@oracle.com, djwong@kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: Clear W=1 warning in xfs_iwalk_run_callbacks():
Date: Thu, 25 Apr 2024 06:30:00 -0700 [thread overview]
Message-ID: <Zipa2CadmKMlERYW@infradead.org> (raw)
In-Reply-To: <01b8050a-b564-4843-8fec-dfa40489aaf4@oracle.com>
On Thu, Apr 25, 2024 at 02:24:28PM +0100, John Garry wrote:
> On 25/04/2024 13:17, Christoph Hellwig wrote:
> > On Thu, Apr 25, 2024 at 12:08:45PM +0000, John Garry wrote:
> > > + struct xfs_inobt_rec_incore __maybe_unused *irec;
> >
> > I've never seen code where __maybe_unused is the right answer, and this
> > is no exception.
>
> Then what about 9798f615ad2be?
Also not great and should be fixed.
(it also wasn't in the original patch and only got added working around
some debug warnings)
next prev parent reply other threads:[~2024-04-25 13:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 12:08 [PATCH 0/2] xfs: Clear a couple of W=1 warnings John Garry
2024-04-25 12:08 ` [PATCH 1/2] xfs: Clear W=1 warning in xfs_iwalk_run_callbacks(): John Garry
2024-04-25 12:17 ` Christoph Hellwig
2024-04-25 13:24 ` John Garry
2024-04-25 13:30 ` Christoph Hellwig [this message]
2024-04-25 13:33 ` John Garry
2024-04-25 15:37 ` John Garry
2024-04-25 16:17 ` Darrick J. Wong
2024-04-25 23:30 ` Dave Chinner
2024-04-26 6:09 ` Christoph Hellwig
2024-05-01 8:10 ` John Garry
2024-04-25 12:08 ` [PATCH 2/2] xfs: Clear W=1 warning in xfs_trans_unreserve_and_mod_sb(): John Garry
2024-04-25 12:18 ` Christoph Hellwig
2024-04-25 13:35 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zipa2CadmKMlERYW@infradead.org \
--to=hch@infradead.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox