From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Chandan Babu R <chandanbabu@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix xfs_init_attr_trans not handling explicit operation codes
Date: Tue, 21 May 2024 06:51:07 -0700 [thread overview]
Message-ID: <Zkymy4s5LtabyMRm@infradead.org> (raw)
In-Reply-To: <20240521010338.GL25518@frogsfrogsfrogs>
On Mon, May 20, 2024 at 06:03:38PM -0700, Darrick J. Wong wrote:
> + tres->tr_logcount = XFS_ATTRSET_LOG_COUNT;
> tres->tr_logflags = XFS_TRANS_PERM_LOG_RES;
> + return args->total;
Seems like indentation is off for the XFS_TRANS_PERM_LOG_RES
assignment?
Also wju does this need to return args->total vs just handling it
in the caller?
> +/* Initialize transaction reservation for an xattr remove */
> +unsigned int
> +xfs_attr_init_remove_trans(
> + struct xfs_da_args *args,
> + struct xfs_trans_res *tres)
> +{
> + struct xfs_mount *mp = args->dp->i_mount;
> +
> + *tres = M_RES(mp)->tr_attrrm;
> + return XFS_ATTRRM_SPACE_RES(mp);
And do we even need this helper vs open coding it like we do in
most transaction allocations?
next prev parent reply other threads:[~2024-05-21 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 1:03 [PATCH] xfs: fix xfs_init_attr_trans not handling explicit operation codes Darrick J. Wong
2024-05-21 13:51 ` Christoph Hellwig [this message]
2024-05-21 15:51 ` Darrick J. Wong
2024-05-21 16:05 ` [PATCH v2] " Darrick J. Wong
2024-05-21 16:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zkymy4s5LtabyMRm@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox