[PATCHSET 1/3] fstests: random fixes for v2024.05.26

[PATCHSET 1/3] fstests: random fixes for v2024.05.26

[Darrick J. Wong]

Hi all,

Here's the usual odd fixes for fstests.  Most of these are cleanups and
bug fixes that have been aging in my djwong-wtf branch forever.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been running on the djcloud for months with no problems.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=random-fixes

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=random-fixes

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=random-fixes
---
Commits in this patchset:
 * generic/747: redirect mkfs stderr to seqres.full
---
 tests/generic/747 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/1] generic/747: redirect mkfs stderr to seqres.full

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

ext4 fails on this test with:

--- /tmp/fstests/tests/generic/747.out	2024-05-13 06:05:59.727025928 -0700
+++ /var/tmp/fstests/generic/747.out.bad	2024-05-21 18:34:51.836000000 -0700
@@ -1,4 +1,5 @@
 QA output created by 747
+mke2fs 1.47.2~WIP-2024-05-21 (21-May-2024)
 Starting fillup using direct IO
 Starting mixed write/delete test using direct IO
 Starting mixed write/delete test using buffered IO

The reason for this is that mke2fs annoyingly prints the program version
to stderr, which messes up the golden output.  Fix this by redirecting
stderr like all the othe tests, even though this doesn't seem like a
great solution...

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/747 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/tests/generic/747 b/tests/generic/747
index 50b7ae1160..bae1c84237 100755
--- a/tests/generic/747
+++ b/tests/generic/747
@@ -99,7 +99,7 @@ seed=$RANDOM
 RANDOM=$seed
 echo "Running test with seed=$seed" >>$seqres.full
 
-_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full
+_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) &>>$seqres.full
 _scratch_mount
 
 echo "Starting fillup using direct IO"

Re: [PATCH 1/1] generic/747: redirect mkfs stderr to seqres.full

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>