public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Wengang Wang <wen.gang.wang@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2] xfs: make sure sb_fdblocks is non-negative
Date: Fri, 31 May 2024 21:52:11 -0700	[thread overview]
Message-ID: <Zlqo-zWI2UUI1lXf@infradead.org> (raw)
In-Reply-To: <20240531182918.5933-1-wen.gang.wang@oracle.com>

On Fri, May 31, 2024 at 11:29:18AM -0700, Wengang Wang wrote:
> -		mp->m_sb.sb_fdblocks = percpu_counter_sum(&mp->m_fdblocks);
> +		mp->m_sb.sb_fdblocks = percpu_counter_sum_positive(&mp->m_fdblocks);

Please break the line to ensure it isn't overly long

		mp->m_sb.sb_fdblocks =
			percpu_counter_sum_positive(&mp->m_fdblocks);

With that:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2024-06-01  4:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 18:29 [PATCH V2] xfs: make sure sb_fdblocks is non-negative Wengang Wang
2024-06-01  4:52 ` Christoph Hellwig [this message]
2024-06-01 17:46 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zlqo-zWI2UUI1lXf@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=wen.gang.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox