From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Chandan Babu R <chandanbabu@kernel.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: allow unlinked symlinks and dirs with zero size
Date: Mon, 10 Jun 2024 21:50:33 -0700 [thread overview]
Message-ID: <ZmfXmebrxnQy3OWI@infradead.org> (raw)
In-Reply-To: <20240610210723.GU52987@frogsfrogsfrogs>
On Mon, Jun 10, 2024 at 02:07:23PM -0700, Darrick J. Wong wrote:
> It turns out that even this is still buggy because directories that are
> being inactivated (e.g. after repair has replaced the contents) can have
> zero isize. Sooo I'll have a new patch in a day or two.
Isn't that what this patch checks for? Or do you mean inactivated
with non-zero nlink?
Btw, it might make sense to add a helper or local variable to check
for an unlinked dinode instead of open coding the v1 check twice in
this function.
next prev parent reply other threads:[~2024-06-11 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 16:12 [PATCH] xfs: allow unlinked symlinks and dirs with zero size Darrick J. Wong
2024-06-09 6:33 ` Christoph Hellwig
2024-06-10 21:07 ` Darrick J. Wong
2024-06-11 4:50 ` Christoph Hellwig [this message]
2024-06-11 6:07 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmfXmebrxnQy3OWI@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox