Re: [PATCH v2 3/4] xfs_fsr: correct type in fsrprintf() call

[Bill O'Donnell <bodonnel@redhat.com>]

On Thu, Jun 13, 2024 at 08:54:08PM -0700, Darrick J. Wong wrote:
> On Thu, Jun 13, 2024 at 04:09:17PM -0500, Bill O'Donnell wrote:
> > Use %ld instead of %d for howlong variable.
> > 
> > Coverity-id: 1596598
> > 
> > Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
> > ---
> >  fsr/xfs_fsr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> > index fdd37756..d204e3a4 100644
> > --- a/fsr/xfs_fsr.c
> > +++ b/fsr/xfs_fsr.c
> > @@ -426,7 +426,7 @@ fsrallfs(char *mtab, time_t howlong, char *leftofffile)
> >  	fsdesc_t *fsp;
> >  	struct stat sb, sb2;
> >  
> > -	fsrprintf("xfs_fsr -m %s -t %d -f %s ...\n", mtab, howlong, leftofffile);
> > +	fsrprintf("xfs_fsr -m %s -t %ld -f %s ...\n", mtab, howlong, leftofffile);
> 
> The exact definition of time_t varies by platform and architecture.
> I'd paste that is, but in libc it's a twisty mess of indirection that
> eventually ends at 'signed long int' or 'long long int'.
> 
> Either way, some linter is likely to balk at this, so you might as well
> cast howlong to (long long) and use %lld here.

Good idea. I'll send a v3.
Thanks-
Bill


> 
> --D
> 
> >  
> >  	endtime = starttime + howlong;
> >  	fs = fsbase;
> > -- 
> > 2.45.2
> > 
> > 
>