From: Christoph Hellwig <hch@infradead.org>
To: alexjlzheng@gmail.com
Cc: hch@infradead.org, alexjlzheng@tencent.com,
chandan.babu@oracle.com, david@fromorbit.com, djwong@kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: make xfs_log_iovec independent from xfs_log_vec and release it early
Date: Tue, 25 Jun 2024 04:34:14 -0700 [thread overview]
Message-ID: <ZnqrNi-cEjs92-b8@infradead.org> (raw)
In-Reply-To: <20240625112438.1925184-1-alexjlzheng@tencent.com>
On Tue, Jun 25, 2024 at 07:24:38PM +0800, alexjlzheng@gmail.com wrote:
> I am sorry, but I didn't get your point. May I ask if you could clarify your
> viewpoint more clearly?
The explanation you gave in reply to Darrick should be covered in
the commit log for the patch. The commit log should also contain
measurement of how much memory this saves and explain why this is a
good trafeoff vs the extra memory allocation.
next prev parent reply other threads:[~2024-06-25 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 12:31 [PATCH] xfs: make xfs_log_iovec independent from xfs_log_vec and release it early alexjlzheng
2024-06-24 15:25 ` Darrick J. Wong
2024-06-24 16:06 ` Jinliang Zheng
2024-06-25 11:14 ` Christoph Hellwig
2024-06-25 11:24 ` alexjlzheng
2024-06-25 11:34 ` Christoph Hellwig [this message]
2024-06-25 11:33 ` Christoph Hellwig
2024-06-26 5:07 ` Jinliang Zheng
2024-06-25 21:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnqrNi-cEjs92-b8@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).