From: Dave Chinner <david@fromorbit.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: chandan.babu@oracle.com, djwong@kernel.org,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: convert comma to semicolon
Date: Tue, 9 Jul 2024 20:01:04 +1000 [thread overview]
Message-ID: <Zo0KYMJkWYirUx1R@dread.disaster.area> (raw)
In-Reply-To: <20240709073632.1152995-1-nichen@iscas.ac.cn>
On Tue, Jul 09, 2024 at 03:36:32PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
Fixes: 8f4b980ee67f ("xfs: pass the attr value to put_listent when possible")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> fs/xfs/xfs_attr_list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 5c947e5ce8b8..7db386304875 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -139,7 +139,7 @@ xfs_attr_shortform_list(
> sbp->name = sfe->nameval;
> sbp->namelen = sfe->namelen;
> /* These are bytes, and both on-disk, don't endian-flip */
> - sbp->value = &sfe->nameval[sfe->namelen],
> + sbp->value = &sfe->nameval[sfe->namelen];
> sbp->valuelen = sfe->valuelen;
> sbp->flags = sfe->flags;
> sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags,
Looks good,
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-07-09 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 7:36 [PATCH] xfs: convert comma to semicolon Chen Ni
2024-07-09 10:01 ` Dave Chinner [this message]
2024-07-09 21:57 ` Darrick J. Wong
2024-07-12 17:40 ` Chaitanya Kulkarni
-- strict thread matches above, loose matches on Subject: below --
2024-07-16 8:01 Chen Ni
2024-07-18 15:27 ` Darrick J. Wong
2024-09-03 7:39 Chen Ni
2024-09-16 16:56 ` Darrick J. Wong
2026-03-06 1:48 [PATCH] xfs: Convert " Chen Ni
2026-03-06 8:41 ` Carlos Maiolino
2026-03-06 8:48 ` Joarder, Souptick
2026-03-10 8:52 ` Carlos Maiolino
2026-03-11 8:08 ` Chen Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo0KYMJkWYirUx1R@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox