From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: alexjlzheng@gmail.com, chandan.babu@oracle.com,
djwong@kernel.org, hch@infradead.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
alexjlzheng@tencent.com
Subject: Re: [PATCH v3 2/2] xfs: make xfs_log_iovec independent from xfs_log_vec and free it early
Date: Sun, 30 Jun 2024 21:49:03 -0700 [thread overview]
Message-ID: <ZoI1P1KQzQVVUzny@infradead.org> (raw)
In-Reply-To: <ZoH9gVVlwMkQO1dm@dread.disaster.area>
On Mon, Jul 01, 2024 at 10:51:13AM +1000, Dave Chinner wrote:
> Here's the logic - the iovec array is largely "free" with the larger
> data allocation.
What the patch does it to free the data allocation, that is the shadow
buffer earlier. Which would safe a quite a bit of memory indeed ... if
we didn't expect the shadow buffer to be needed again a little later
anyway, which AFAIK is the assumption under which the CIL code operates.
So as asked previously and by you again here I'd love to see numbers
for workloads where this actually is a benefit.
next prev parent reply other threads:[~2024-07-01 4:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 4:49 [PATCH v3 0/2] Separate xfs_log_vec/iovec to save memory alexjlzheng
2024-06-26 4:49 ` [PATCH v3 1/2] xfs: add xfs_log_vec_cache for separate xfs_log_vec/xfs_log_iovec alexjlzheng
2024-06-26 4:49 ` [PATCH v3 2/2] xfs: make xfs_log_iovec independent from xfs_log_vec and free it early alexjlzheng
2024-07-01 0:51 ` Dave Chinner
2024-07-01 4:49 ` Christoph Hellwig [this message]
2024-07-02 23:44 ` Dave Chinner
2024-07-03 5:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoI1P1KQzQVVUzny@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).