From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C13A6BA39 for ; Mon, 1 Jul 2024 02:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719801281; cv=none; b=AhS4/i1X344uT/1kMxu4/m+vvnrOPs9/qr12Hi3rw4CbPFOkZ3RfnSxpAY1eVcwN8309WK049vyyQ+P36kf/omWHhWoymHpyGzQH7TRoTNY598Gw0BQw0uyw55LFhFaVk1UJX4jA8bDmbXpvdnfX5BQrz0I1+Jrx8Dq/TKudhBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719801281; c=relaxed/simple; bh=DlkcM4SlWpgQaq76rEi7Pgs0fMGW100ZEJIUZ8O4bdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cfKvWT0L7t+eCFcpdtqsSFFWUmE1N172MBfmBr1sxwF3csx3YhTc+E/MGEX99nhku5OeqmR+pqp0imJWFt/yekkQfW9dEYN6ZNpySP0WY4GD1YiFyWaHJaxM0Y7buDAyAVfVKFwTj94LsJCEswi+D8UCnp5KM1IOpP+Btg+IXlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=wMVytl2h; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="wMVytl2h" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5c40f0aed5bso919179eaf.2 for ; Sun, 30 Jun 2024 19:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1719801278; x=1720406078; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DDgWV/1M0ZHGACEenRn+Ob+1qKeNo9iohlOwDr3DlCI=; b=wMVytl2hXErjqhBwnoFOH+8yQshav5x/7Zrtr8npl2OGEY28pJl9AaE5cFHxDy1SMz U4rPDt9Nyzc3qzES9T864inMv6wewv7WQ9MsnwgVbrJD8J4MZ0VrT2eyRFAd3AXpzhWM 8u4aCgA5XY5rkTFWgAe1cXR03rQ64bNUGHg4kELyLMKFr2PCZ5Mx8G+GFmgkA7n/fJ77 a/NeBvcS4k80KBsWWzc0YbNyP+H7rcQBNsakXH0S0FOfbQTXxpkMCap3eT7Ai5jgmPmX xDNF3xQeuHTN9K1iL5KLM7exYRKq4garLvFpEmJ0KMAomgX23hzWV81TRoGfwy+XbgAn 5fwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719801278; x=1720406078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DDgWV/1M0ZHGACEenRn+Ob+1qKeNo9iohlOwDr3DlCI=; b=w7FwUgXCeZI/OhqhRhXkoHE3WMGLcXOL6oo1MVF1QgOOsdoxg0yTEWtRVrKqeetaFu YxB4XUA73pQtZFyRhyeS6ADU9DaG7FQuM0E/AhGfF+ZqLw3qy2g6Vzbg0B025EsGlJFo kGbI2HLvxGZUqBSkqX1b+GEYAXhjDFVrEvrH9Sxoo4/AmhQ1zMk+dsQCONRq7aPAu4Hk 3oAwuZOnGg/aB7EDzFeetYfttB3eQSIkkdZCO4nLH0xjPpls24PBGmS3iBNufwEXYA4N IqHJ8ou6hwlKJx4eaWvH3Z1c/tcnOA0MSveFnrxprONDGU/k676997JR5B2PIoCtyrnD RFQw== X-Forwarded-Encrypted: i=1; AJvYcCUOOU0ZxxZe3+fvBhzQ6Ds9YUV/n3FRvBdY7XB90PtC9IsUSyN91KEVp0RhjDY+H7yM5NfirJt0Cb68oUoxqotYceTgARKNgvP9 X-Gm-Message-State: AOJu0YzQd2v9rP19Vor/VuwN1EqDP86Q6+jd0Lu+5ue+XP/wbRisajQ6 DLtfSUIZ2doiCEyo/QbwRu8rXxuP64FrSxfUHGIuS+ysnUghwzrA39Y32kZt1yQ= X-Google-Smtp-Source: AGHT+IGgOd34C7aRGMh1d04uXW7hNhMkkm6eNwIGWoMV3VIS98zXVTuuNpmdYFB3rotkj3bxL+qTug== X-Received: by 2002:a05:6358:78c:b0:1a6:7af3:22ca with SMTP id e5c5f4694b2df-1a6acefbf70mr99620155d.32.1719801277568; Sun, 30 Jun 2024 19:34:37 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6b0adfb1sm3536332a12.44.2024.06.30.19.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 19:34:37 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sO6sE-00HR0O-37; Mon, 01 Jul 2024 12:34:34 +1000 Date: Mon, 1 Jul 2024 12:34:34 +1000 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 10/10] xfs: enable block size larger than page size support Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-11-kernel@pankajraghav.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625114420.719014-11-kernel@pankajraghav.com> On Tue, Jun 25, 2024 at 11:44:20AM +0000, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Page cache now has the ability to have a minimum order when allocating > a folio which is a prerequisite to add support for block size > page > size. > > Reviewed-by: Darrick J. Wong > Signed-off-by: Luis Chamberlain > Signed-off-by: Pankaj Raghav > --- > @hch and @Dave I have retained the min_folio_order to be in the inode > struct as the discussion about moving this to xfs_mount is still open. > > fs/xfs/libxfs/xfs_ialloc.c | 5 +++++ > fs/xfs/libxfs/xfs_shared.h | 3 +++ > fs/xfs/xfs_icache.c | 6 ++++-- > fs/xfs/xfs_mount.c | 1 - > fs/xfs/xfs_super.c | 18 ++++++++++-------- > 5 files changed, 22 insertions(+), 11 deletions(-) all looks fine to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com