From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F7B17A5B0 for ; Tue, 2 Jul 2024 23:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719964286; cv=none; b=D/TNFcZFSGslHiyCp+ADU4/od4knZmyBACK0e3WXJ/iMoie057QkZ6ADqVPIizepXRXZaAMJUtlF2XJFWk6+CLzY5QE1Ivj3xk6Kx4VyDo3/YcEWbcRM27pQQ3nYXr1k8ZZGFpB+nCuhro1aL9beDnwiTUVqvxf+Wpb0sclR4lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719964286; c=relaxed/simple; bh=heOKtfnADzMhe/MoJhYhpLsd+GdXsFugF2eub9FrScg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DYs5cr6DsnCEr07baZFyHbsa3JOQkvcZ1ES0dzAZkHtLcQ/UdlzcdExJKYVl/8+9MY/deN6H9KXdNlmzWQipOeMavdgl8h4X0fxZXigYqVWH7Aj7cZFM2wAV41Sy0SaWb22VaGFmSrBOkfHgkfRqb3HBls9KhAcPBvBluUE/L50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=qmA1GX+j; arc=none smtp.client-ip=209.85.160.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="qmA1GX+j" Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-25caf76158cso2811064fac.0 for ; Tue, 02 Jul 2024 16:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1719964284; x=1720569084; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z6du070xXmJymYEkb83ctmWy++Rs5iSF330UqSLYNCw=; b=qmA1GX+jeD44Nf2TCuil1bgkdpTUSUlT60TsgmIqFabhX1uSLnOFlRxX29w4hEEnzy T/UUS7TbigHqsgcbzE0HEOejCAG8WutcNCtV9Vp6FlUz6OQPOcfrpfBHnMCYtJ16b09X ogL2bCc8ghKwNoLqkGFxnG+vfe1GyH/9/3dbauhXYKIknf5Ks8YT5GJvTBeMC65BAvoY QFXzt6VKFLJQvJnHkIDVRpKXsA5TkOIzVZh/cvcdVrOr4CJpamBc8GAEi6B9RIhUR91S 4RNVO3qX7tMrZi83/E2cLPIr9nzMF2MWu6pBgMqq8TlIOvKja+1dDHSmTHM+P9z43mUI Rk1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719964284; x=1720569084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z6du070xXmJymYEkb83ctmWy++Rs5iSF330UqSLYNCw=; b=v55+8Cq1g9gjla1TVrNAC1ciuZfFBwInNkHonSghzkLAJLDUJAHkc/PwkyhS/pIwQ7 jiwnq2gcvuNskumcg1UK2wMPzrbuWcjLNwJ7GYAKa09lI0b0s1yXxhOi3hXhqyFPcv1p k0dgEf8j0i6/1nVxOhZ0StSwHdzJH9mawD4l02BjYi/dVXiMZ/6oLMolcBKKDqTnXii9 oWqo2n0JoBu0jr77ybrpRHZdeo0K+3n8u+17ACftsEjXJBXud7SIs1gNxmlO+i2JGn6Z XnE5BGm8tsjLLy00pt0k/jvpfaMqOmJQkVtRXnlZO7mPU0usZudYBG7LUuLGIRXs3Z45 HyDQ== X-Forwarded-Encrypted: i=1; AJvYcCUIlUdqE2b9lIPWZPpLDdvR7S0jCa8KiWgVDrGaid0dRDeGe7Jg6389IIL/OdkyhakBnlQGxI7lrLE8vO9VMJwHpeMuvNFQY4ji X-Gm-Message-State: AOJu0Yxw4ke5kH3VAySxa114DcIO0veJMh8ghH+uOEn3UzXqWsazw0KN gAVvKvPUd7dhvELE+X2iMe8ndQO6dQ9leV6hrt1y3sPYjtS/2fj73hW6qCvQrhg= X-Google-Smtp-Source: AGHT+IE46R4zd9/ivoUu+xK+/d8ah4zUHfBbtR8DaUUQK//8dih0yO9NWu4bkwyIHHyzpj2W21Egwg== X-Received: by 2002:a05:6870:472b:b0:254:b74e:d654 with SMTP id 586e51a60fabf-25db340df76mr9180217fac.22.1719964283556; Tue, 02 Jul 2024 16:51:23 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-708044adb21sm9401789b3a.141.2024.07.02.16.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 16:51:22 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sOnHL-00230I-3C; Wed, 03 Jul 2024 09:51:20 +1000 Date: Wed, 3 Jul 2024 09:51:19 +1000 From: Dave Chinner To: Christoph Hellwig Cc: Mike Snitzer , linux-xfs@vger.kernel.org, Brian Foster , linux-nfs@vger.kernel.org Subject: Re: [PATCH v2] xfs: enable WQ_MEM_RECLAIM on m_sync_workqueue Message-ID: References: Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Jun 30, 2024 at 09:45:40PM -0700, Christoph Hellwig wrote: > On Mon, Jul 01, 2024 at 09:46:36AM +1000, Dave Chinner wrote: > > Oh, that's nasty. > > Yes. > > > We now have to change every path in every filesystem that NFS can > > call that might defer work to a workqueue. > > Yes. That's why the kernel for a long time had the stance that using > network file systems / storage locally is entirely unsupported. > > If we want to change that we'll have a lot of work to do. Yep. These sorts of changes really need to be cc'd to linux-fsdevel, not kept private to the NFS lists. I wouldn't have known that NFS was going to do local IO to filesystems if it wasn't for this patch, and it's clear the approach being taken needs architectural review before we even get down into the nitty gritty details of the implementation. Mike, can you make sure that linux-fsdevel@vger.kernel.org is cc'd on all the localio work being posted so we can all keep track of it easily? -Dave. -- Dave Chinner david@fromorbit.com