From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Chandan Babu R <chandanbabu@kernel.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: honor init_xattrs in xfs_init_new_inode for !attr && attr2 fs
Date: Thu, 11 Jul 2024 22:28:29 -0700 [thread overview]
Message-ID: <ZpC-_Rv4nPa2Bw3z@infradead.org> (raw)
In-Reply-To: <ZpB5fS822UrP6JIs@dread.disaster.area>
On Fri, Jul 12, 2024 at 10:31:57AM +1000, Dave Chinner wrote:
> Suggesting that someone else should do the work to tidy up the loose
> on-disk format ends in the kernel and userspace in preference to a
> one line hack that works around the problem goes against all the
> agreements we've had for bringing experimental code up to production
> quality. This isn't how to engineer high quality, robust long lived
> code...
I don't think it is entirely unreasonable. The code works totally
fine by not forcing attr for parent as Darrick pointed out. It's
also kinda suboptimal and stupid as you pointed out. So if you care
about it, just sending a patch would be a lot nicer than ranting.
prev parent reply other threads:[~2024-07-12 5:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 23:21 [PATCH] xfs: honor init_xattrs in xfs_init_new_inode for !attr && attr2 fs Darrick J. Wong
2024-06-19 1:06 ` Darrick J. Wong
2024-06-19 5:25 ` Christoph Hellwig
2024-06-19 16:00 ` Darrick J. Wong
2024-07-01 1:27 ` Dave Chinner
2024-07-01 23:37 ` Darrick J. Wong
2024-07-12 0:31 ` Dave Chinner
2024-07-12 5:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpC-_Rv4nPa2Bw3z@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).