Re: [PATCH 2/6] xfs: use metadir for quota inodes

Darrick J. Wong
2024-08-23T18:20:22Z

On Thu, Aug 22, 2024 at 10:53:00PM -0700, Christoph Hellwig wrote:
> On Thu, Aug 22, 2024 at 05:28:28PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Store the quota inodes in a metadata directory if metadir is enabled.
>
> I think this commit log could explain a bit better what this means
> and why it is done.

How about:

"Store the quota inodes in the /quota metadata directory if metadir is
enabled. This enables us to stop using the sb_[ugp]uotino fields in the
superblock. From this point on, all metadata files will be children of
the metadata directory tree root."

> Otherwis looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D