Re: [PATCH] xfs: test log recovery for extent frees right after growfs

Brian Foster
2024-10-09T15:13:45Z

On Wed, Oct 09, 2024 at 02:43:16PM +0200, Christoph Hellwig wrote:
> On Wed, Oct 09, 2024 at 08:35:46AM -0400, Brian Foster wrote:
> > Ok, so then what happened? :) Are there outstanding patches somewhere to
> > fix this problem? If so, I can give it a test with this.
>
> Yes, "fix recovery of allocator ops after a growfs" from Sep 30.
>

Thanks. This seems to fix the unmountable fs problem, so I'd guess it's
reproducing something related.

The test still fails occasionally with a trans abort and I see some
bnobt/cntbt corruption messages like the one appended below, but I'll
leave to you to decide whether this is a regression or preexisting
problem.

I probably won't get through it today, but I'll try to take a closer
look at the patches soon..

Brian

...
XFS (vdb2): cntbt record corruption in AG 8 detected at xfs_alloc_check_irec+0xfa/0x160 [xfs]!
XFS (vdb2): start block 0xa block count 0x1f36
XFS (vdb2): Internal error xfs_trans_cancel at line 872 of file fs/xfs/xfs_trans.c. Caller xfs_symlink+0x5a6/0xbd0 [xfs]
CPU: 5 UID: 0 PID: 8625 Comm: fsstress Tainted: G E 6.12.0-rc2+ #251
Tainted: [E]=UNSIGNED_MODULE
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014
Call Trace:
<TASK>
dump_stack_lvl+0x8d/0xb0
xfs_trans_cancel+0x3ca/0x530 [xfs]
xfs_symlink+0x5a6/0xbd0 [xfs]
? __pfx_xfs_symlink+0x10/0x10 [xfs]
? avc_has_perm+0x77/0x110
? lock_is_held_type+0xcd/0x120
? __pfx_avc_has_perm+0x10/0x10
? avc_has_perm_noaudit+0x3a/0x280
? may_create+0x26a/0x2e0
xfs_vn_symlink+0x144/0x390 [xfs]
? __pfx_selinux_inode_permission+0x10/0x10
? __pfx_xfs_vn_symlink+0x10/0x10 [xfs]
vfs_symlink+0x33e/0x580
do_symlinkat+0x1cf/0x250
? __pfx_do_symlinkat+0x10/0x10
? getname_flags.part.0+0xae/0x490
__x64_sys_symlink+0x71/0x90
do_syscall_64+0x93/0x180
? do_syscall_64+0x9f/0x180
entry_SYSCALL_64_after_hwframe+0x76/0x7e
RIP: 0033:0x7fcb692378eb
Code: 8b 0d 49 f5 0c 00 f7 d8 64 89 01 b9 ff ff ff ff eb d3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 f3 0f 1e fa b8 58 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 05 c3 0f 1f 40 00 48 8b 15 11 f5 0c 00 f7 d8
RSP: 002b:00007ffc547e52e8 EFLAGS: 00000206 ORIG_RAX: 0000000000000058
RAX: ffffffffffffffda RBX: 000000003804a200 RCX: 00007fcb692378eb
RDX: 0000000000000000 RSI: 0000000038049200 RDI: 000000003804a200
RBP: 0000000038049200 R08: 000000003804a440 R09: 00007fcb69307b20
R10: 0000000000000270 R11: 0000000000000206 R12: 000000003804a200
R13: 00007ffc547e5450 R14: 0000000078ba5238 R15: 00007fcb6912c6c8