From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Carlos Maiolino <cem@kernel.org>, xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix simplify extent lookup in xfs_can_free_eofblocks
Date: Wed, 2 Oct 2024 08:11:17 -0700 [thread overview]
Message-ID: <Zv1ilUMwSOVeT1Q_@infradead.org> (raw)
In-Reply-To: <20241002145921.GA21853@frogsfrogsfrogs>
> + if (ip->i_delayed_blks)
> + found_blocks = true;
> + else if (xfs_iext_lookup_extent(ip, &ip->i_df, end_fsb, &icur, &imap))
> found_blocks = true;
This could be simplified a little bit by doing:
if (ip->i_delayed_blks ||
xfs_iext_lookup_extent(ip, &ip->i_df, end_fsb, &icur, &imap))
found_blocks = true;
but otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-02 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:59 [PATCH] xfs: fix simplify extent lookup in xfs_can_free_eofblocks Darrick J. Wong
2024-10-02 15:11 ` Christoph Hellwig [this message]
2024-10-02 21:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1ilUMwSOVeT1Q_@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).