[PATCH] xfs: Fix a typo

[PATCH] xfs: Fix a typo

[Bhaskar Chowdhury]

s/strutures/structures/

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 fs/xfs/xfs_aops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index b4186d666157..1cc7c36d98e9 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -158,7 +158,7 @@ xfs_end_ioend(
 	nofs_flag = memalloc_nofs_save();

 	/*
-	 * Just clean up the in-memory strutures if the fs has been shut down.
+	 * Just clean up the in-memory structures if the fs has been shut down.
 	 */
 	if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
 		error = -EIO;
--
2.31.0

Re: [PATCH] xfs: Fix a typo

[Pavel Reichl]

On 3/22/21 7:39 AM, Bhaskar Chowdhury wrote:
> 
> s/strutures/structures/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  fs/xfs/xfs_aops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index b4186d666157..1cc7c36d98e9 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -158,7 +158,7 @@ xfs_end_ioend(
>  	nofs_flag = memalloc_nofs_save();
> 
>  	/*
> -	 * Just clean up the in-memory strutures if the fs has been shut down.
> +	 * Just clean up the in-memory structures if the fs has been shut down.
>  	 */
>  	if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
>  		error = -EIO;
> --
> 2.31.0
> 

Hi,

LGTM,

Reviewed-by: Pavel Reichl <preichl@redhat.com>

Thanks!

Re: [PATCH] xfs: Fix a typo

[Randy Dunlap]

On 3/21/21 11:39 PM, Bhaskar Chowdhury wrote:
> 
> s/strutures/structures/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  fs/xfs/xfs_aops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index b4186d666157..1cc7c36d98e9 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -158,7 +158,7 @@ xfs_end_ioend(
>  	nofs_flag = memalloc_nofs_save();
> 
>  	/*
> -	 * Just clean up the in-memory strutures if the fs has been shut down.
> +	 * Just clean up the in-memory structures if the fs has been shut down.
>  	 */
>  	if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
>  		error = -EIO;
> --


-- 
~Randy

[PATCH] xfs: fix a typo

[Andrew Kreimer]

Fix a typo in comments.

Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 fs/xfs/xfs_log_recover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index ec766b4bc853..a13bf53fea49 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1849,7 +1849,7 @@ xlog_find_item_ops(
  *	   from the transaction. However, we can't do that until after we've
  *	   replayed all the other items because they may be dependent on the
  *	   cancelled buffer and replaying the cancelled buffer can remove it
- *	   form the cancelled buffer table. Hence they have tobe done last.
+ *	   form the cancelled buffer table. Hence they have to be done last.
  *
  *	3. Inode allocation buffers must be replayed before inode items that
  *	   read the buffer and replay changes into it. For filesystems using the
-- 
2.39.5

Re: [PATCH] xfs: fix a typo

[Darrick J. Wong]

On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> Fix a typo in comments.
> 
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log_recover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index ec766b4bc853..a13bf53fea49 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1849,7 +1849,7 @@ xlog_find_item_ops(
>   *	   from the transaction. However, we can't do that until after we've
>   *	   replayed all the other items because they may be dependent on the
>   *	   cancelled buffer and replaying the cancelled buffer can remove it
> - *	   form the cancelled buffer table. Hence they have tobe done last.
> + *	   form the cancelled buffer table. Hence they have to be done last.
>   *
>   *	3. Inode allocation buffers must be replayed before inode items that
>   *	   read the buffer and replay changes into it. For filesystems using the
> -- 
> 2.39.5
> 
> 

Re: [PATCH] xfs: fix a typo

[Dan Carpenter]

On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> Fix a typo in comments.
> 

Could you explain what the typos are in the commit message so that we can spot
it more easily?  It saves a little review time.

regards,
dan carpenter

Re: [PATCH] xfs: fix a typo

[Andrew Kreimer]

On Thu, Oct 03, 2024 at 08:59:42AM +0300, Dan Carpenter wrote:
> On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> > Fix a typo in comments.
> > 
> 
> Could you explain what the typos are in the commit message so that we can spot
> it more easily?  It saves a little review time.

Noted, thank you.