From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: willy@infradead.org, brauner@kernel.org, cem@kernel.org,
ruansy.fnst@fujitsu.com, linux-fsdevel@vger.kernel.org,
hch@lst.de, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: don't allocate COW extents when unsharing a hole
Date: Fri, 4 Oct 2024 05:07:19 -0700 [thread overview]
Message-ID: <Zv_ad7FI-_LwWp1d@infradead.org> (raw)
In-Reply-To: <172796813277.1131942.5486112889531210260.stgit@frogsfrogsfrogs>
On Thu, Oct 03, 2024 at 08:09:01AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> It doesn't make sense to allocate a COW extent when unsharing a hole
> because holes cannot be shared.
>
> Fixes: 1f1397b7218d7 ("xfs: don't allocate into the data fork for an unshare request")
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-04 12:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 15:08 [PATCHSET] fsdax/xfs: unshare range fixes for 6.12 Darrick J. Wong
2024-10-03 15:09 ` [PATCH 1/4] xfs: don't allocate COW extents when unsharing a hole Darrick J. Wong
2024-10-04 12:07 ` Christoph Hellwig [this message]
2024-10-03 15:09 ` [PATCH 2/4] iomap: share iomap_unshare_iter predicate code with fsdax Darrick J. Wong
2024-10-04 12:07 ` Christoph Hellwig
2024-10-03 15:09 ` [PATCH 3/4] fsdax: remove zeroing code from dax_unshare_iter Darrick J. Wong
2024-10-04 12:09 ` Christoph Hellwig
2024-10-03 15:09 ` [PATCH 4/4] fsdax: dax_unshare_iter needs to copy entire blocks Darrick J. Wong
2024-10-04 12:09 ` Christoph Hellwig
2024-10-07 11:52 ` [PATCHSET] fsdax/xfs: unshare range fixes for 6.12 Christian Brauner
2024-10-25 22:24 ` Darrick J. Wong
2024-10-28 11:14 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv_ad7FI-_LwWp1d@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox