linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-xfs@vger.kernel.org, Ritesh Harjani <ritesh.list@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Darrick J . Wong" <djwong@kernel.org>,
	dchinner@redhat.com, Chandan Babu R <chandan.babu@oracle.com>
Subject: Re: [PATCH] xfs: Check for deallayed allocations before setting extsize
Date: Fri, 4 Oct 2024 05:15:09 -0700	[thread overview]
Message-ID: <Zv_cTc6cgxszKGy3@infradead.org> (raw)
In-Reply-To: <Zv+tfQhBdxuownfv@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>

On Fri, Oct 04, 2024 at 02:26:07PM +0530, Ojaswin Mujoo wrote:
> Hi Christoph, actually now that we are also planning to use this for
> atomic writes, we are thinking to add a generic extsize ioctl 
> test to check for:
> 
> 1. Setting hint on empty file should pass
> 2. Setting hint on a file with delayed allocation data should fail
> 3. Setting hint on a file with allocated data should fail
> 4. Setting hint on a file which is truncated to size 0 after write should pass
> 
> So that should cover this for ext4 and xfs as well.

Sounds good.


      reply	other threads:[~2024-10-04 12:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 10:12 [PATCH] xfs: Check for deallayed allocations before setting extsize Ojaswin Mujoo
2024-10-03 14:38 ` Christoph Hellwig
2024-10-04  8:56   ` Ojaswin Mujoo
2024-10-04 12:15     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zv_cTc6cgxszKGy3@infradead.org \
    --to=hch@infradead.org \
    --cc=chandan.babu@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).