Re: [PATCH 4/8] xfs_db: access realtime file blocks

Christoph Hellwig
2024-10-28T08:37:13Z

> + if (is_rtfile(iocur_top->data))
> + set_rt_cur(&typtab[type], (int64_t)dfsbno << mp->m_blkbb_log,

Shouldn't this be xfs_rtb_to_daddr?

> diff --git a/db/faddr.c b/db/faddr.c
> index ec4aae68bb5a81..fd65b86b5e915d 100644
> --- a/db/faddr.c
> +++ b/db/faddr.c
> @@ -323,7 +323,9 @@ fa_drtbno(
> dbprintf(_("null block number, cannot set new addr\n"));
> return;
> }
> - /* need set_cur to understand rt subvolume */
> +
> + set_rt_cur(&typtab[next], (int64_t)XFS_FSB_TO_BB(mp, bno), blkbb,
> + DB_RING_ADD, NULL);

Same here?