From: Christoph Hellwig <hch@infradead.org>
To: alexjlzheng@gmail.com
Cc: cem@kernel.org, djwong@kernel.org, chandanbabu@kernel.org,
dchinner@redhat.com, zhangjiachen.jaycee@bytedance.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jinliang Zheng <alexjlzheng@tencent.com>
Subject: Re: [PATCH] xfs: fix the judgment of whether the file already has extents
Date: Mon, 28 Oct 2024 02:41:01 -0700 [thread overview]
Message-ID: <Zx9cLakpnJBAV1am@infradead.org> (raw)
In-Reply-To: <20241026180116.10536-1-alexjlzheng@tencent.com>
On Sun, Oct 27, 2024 at 02:01:16AM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
>
> When we call create(), lseek() and write() sequentially, offset != 0
> cannot be used as a judgment condition for whether the file already
> has extents.
>
> This patch uses prev.br_startoff instead of offset != 0.
This changed the predicate from "are we at offset 0" to "are there
any allocations before that". That's a pretty big semantic change.
Maybe a good one, maybe not. Can you explain what workload it helps
you with?
next prev parent reply other threads:[~2024-10-28 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 18:01 [PATCH] xfs: fix the judgment of whether the file already has extents alexjlzheng
2024-10-28 9:41 ` Christoph Hellwig [this message]
2024-10-28 10:33 ` Jinliang Zheng
2024-10-28 10:42 ` Jinliang Zheng
2024-10-29 20:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zx9cLakpnJBAV1am@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=cem@kernel.org \
--cc=chandanbabu@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zhangjiachen.jaycee@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox