From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: zlang@redhat.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] common/xfs: _notrun tests that fail due to block size < sector size
Date: Mon, 21 Oct 2024 22:47:50 -0700 [thread overview]
Message-ID: <Zxc8hoOEc2x129bv@infradead.org> (raw)
In-Reply-To: <172912045609.2583984.9245803618825626168.stgit@frogsfrogsfrogs>
On Wed, Oct 16, 2024 at 04:15:16PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> It makes no sense to fail a test that failed to format a filesystem with
> a block size smaller than the sector size since the test preconditions
> are not valid.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-22 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 23:15 [PATCHSET 1/2] fstests: fix fstests for 64k fsblock size Darrick J. Wong
2024-10-16 23:15 ` [PATCH 1/2] common/xfs: _notrun tests that fail due to block size < sector size Darrick J. Wong
2024-10-22 5:47 ` Christoph Hellwig [this message]
2024-10-23 4:15 ` Zorro Lang
2024-10-16 23:15 ` [PATCH 2/2] xfs/161: adapt the test case for LBS filesystem Darrick J. Wong
2024-10-22 5:48 ` Christoph Hellwig
2024-10-23 4:23 ` Zorro Lang
2024-10-17 9:32 ` [PATCHSET 1/2] fstests: fix fstests for 64k fsblock size Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxc8hoOEc2x129bv@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox