From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs: sb_spino_align is not verified
Date: Fri, 25 Oct 2024 17:33:16 +1100 [thread overview]
Message-ID: <Zxs7rLd951k9EzdA@dread.disaster.area> (raw)
In-Reply-To: <20241024165544.GI21853@frogsfrogsfrogs>
On Thu, Oct 24, 2024 at 09:55:44AM -0700, Darrick J. Wong wrote:
> On Thu, Oct 24, 2024 at 01:51:05PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > It's just read in from the superblock and used without doing any
> > validity checks at all on the value.
> >
> > Fixes: fb4f2b4e5a82 ("xfs: add sparse inode chunk alignment superblock field")
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Cc: <stable@vger.kernel.org> # v4.2
Yeah. And probably what ever fix we decide on, too.
> Oof yeah that's quite a gap!
*nod*
What surprises me is that syzbot hasn't found this - it's exactly
the sort of thing that randomised structure fuzzing is supposed to
find.....
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks!
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-10-25 6:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 2:51 [PATCH 0/3] xfs: sparse inodes overlap end of filesystem Dave Chinner
2024-10-24 2:51 ` [PATCH 1/3] xfs: fix sparse inode limits on runt AG Dave Chinner
2024-10-24 2:51 ` [PATCH 2/3] xfs: allow sparse inode records at the end of runt AGs Dave Chinner
2024-10-24 17:00 ` Darrick J. Wong
2024-10-25 6:43 ` Dave Chinner
2024-10-25 22:19 ` Darrick J. Wong
2024-10-26 21:47 ` Dave Chinner
2024-10-24 2:51 ` [PATCH 3/3] xfs: sb_spino_align is not verified Dave Chinner
2024-10-24 16:55 ` Darrick J. Wong
2024-10-25 6:33 ` Dave Chinner [this message]
2024-12-07 0:25 ` Luis Chamberlain
2024-12-07 0:32 ` Darrick J. Wong
2024-12-07 0:36 ` Luis Chamberlain
2024-12-07 11:34 ` Carlos Maiolino
2024-10-24 13:20 ` [PATCH 0/3] xfs: sparse inodes overlap end of filesystem Brian Foster
2024-10-25 0:48 ` Dave Chinner
2024-10-25 19:33 ` Brian Foster
2024-10-24 16:38 ` Darrick J. Wong
2024-10-25 6:29 ` Dave Chinner
2024-10-29 16:14 ` Eric Sandeen
2024-10-31 11:44 ` Carlos Maiolino
2024-10-31 20:45 ` Eric Sandeen
2024-10-31 22:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxs7rLd951k9EzdA@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox