From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Zorro Lang <zlang@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs/157: mkfs does not need a specific fssize
Date: Tue, 5 Nov 2024 07:02:26 -0800 [thread overview]
Message-ID: <Zyozgri3aa5DoAEN@infradead.org> (raw)
In-Reply-To: <ZynB+0hF1Bo6p0Df@dread.disaster.area>
On Tue, Nov 05, 2024 at 05:58:03PM +1100, Dave Chinner wrote:
> When the two conflict, _scratch_mkfs drops the global MKFS_OPTIONS
> and uses only the local parameters so the filesystem is set up with
> the configuration the test expects.
>
> In this case, MKFS_OPTIONS="-m rmapbt=1" which conflicts with the
> local RTDEV/USE_EXTERNAL test setup. Because the test icurrently
> overloads the global MKFS_OPTIONS with local test options, the local
> test parameters are dropped along with the global paramters when
> there is a conflict. Hence the mkfs_scratch call fails to set the
> filesystem up the way the test expects.
But the rmapbt can be default on, in which case it does not get
removed. And then without the _sized we'll run into the problem that
Hans' patches fixed once again.
next prev parent reply other threads:[~2024-11-05 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 19:35 [PATCH] xfs/157: mkfs does not need a specific fssize Zorro Lang
2024-10-31 22:08 ` Darrick J. Wong
2024-11-01 5:48 ` Zorro Lang
2024-11-01 21:49 ` Darrick J. Wong
2024-11-04 7:50 ` Christoph Hellwig
2024-11-04 13:04 ` Zorro Lang
2024-11-04 23:34 ` Darrick J. Wong
2024-11-05 6:58 ` Dave Chinner
2024-11-05 15:02 ` Christoph Hellwig [this message]
2024-11-05 15:47 ` Darrick J. Wong
2024-11-07 5:40 ` Dave Chinner
2024-11-07 10:10 ` Zorro Lang
2024-11-07 23:53 ` Darrick J. Wong
2024-11-14 23:43 ` Darrick J. Wong
2024-11-05 6:58 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyozgri3aa5DoAEN@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox