Re: [PATCH] xfs/157: mkfs does not need a specific fssize

[Dave Chinner <david@fromorbit.com>]

On Tue, Nov 05, 2024 at 07:47:12AM -0800, Darrick J. Wong wrote:
> On Tue, Nov 05, 2024 at 07:02:26AM -0800, Christoph Hellwig wrote:
> > On Tue, Nov 05, 2024 at 05:58:03PM +1100, Dave Chinner wrote:
> > > When the two conflict, _scratch_mkfs drops the global MKFS_OPTIONS
> > > and uses only the local parameters so the filesystem is set up with
> > > the configuration the test expects.
> > > 
> > > In this case, MKFS_OPTIONS="-m rmapbt=1" which conflicts with the
> > > local RTDEV/USE_EXTERNAL test setup. Because the test icurrently
> > > overloads the global MKFS_OPTIONS with local test options, the local
> > > test parameters are dropped along with the global paramters when
> > > there is a conflict. Hence the mkfs_scratch call fails to set the
> > > filesystem up the way the test expects.
> > 
> > But the rmapbt can be default on, in which case it does not get
> > removed.  And then without the _sized we'll run into the problem that
> > Hans' patches fixed once again.
> 
> Well we /could/ make _scratch_mkfs_sized pass options through to the
> underlying _scratch_mkfs.

That seems like the right thing to do to me.

-Dave.
-- 
Dave Chinner
david@fromorbit.com