From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
hch@infradead.org, djwong@kernel.org
Subject: Re: [PATCH v4 2/3] iomap: lift zeroed mapping handling into iomap_zero_range()
Date: Sun, 17 Nov 2024 22:29:50 -0800 [thread overview]
Message-ID: <Zzre3i7UZARRpVgC@infradead.org> (raw)
In-Reply-To: <20241115200155.593665-3-bfoster@redhat.com>
On Fri, Nov 15, 2024 at 03:01:54PM -0500, Brian Foster wrote:
> In preparation for special handling of subranges, lift the zeroed
> mapping logic from the iterator into the caller. Since this puts the
> pagecache dirty check and flushing in the same place, streamline the
> comments a bit as well.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
I don't want to block this improvement on stylistic things, but
I still don't like moving more code than the function invocation into
the iter body. I hope you're okay with me undoing that sooner or later.
next prev parent reply other threads:[~2024-11-18 6:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 20:01 [PATCH v4 0/3] iomap: zero range flush fixes Brian Foster
2024-11-15 20:01 ` [PATCH v4 1/3] iomap: reset per-iter state on non-error iter advances Brian Foster
2024-11-15 20:01 ` [PATCH v4 2/3] iomap: lift zeroed mapping handling into iomap_zero_range() Brian Foster
2024-11-18 6:29 ` Christoph Hellwig [this message]
2024-11-18 13:54 ` Brian Foster
2024-11-18 14:14 ` Christoph Hellwig
2024-11-15 20:01 ` [PATCH v4 3/3] iomap: elide flush from partial eof zero range Brian Foster
2024-11-20 8:33 ` [PATCH v4 0/3] iomap: zero range flush fixes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zzre3i7UZARRpVgC@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox