From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
djwong@kernel.org
Subject: Re: [PATCH v4 2/3] iomap: lift zeroed mapping handling into iomap_zero_range()
Date: Mon, 18 Nov 2024 06:14:26 -0800 [thread overview]
Message-ID: <ZztLwrkl4Qlbm5Ku@infradead.org> (raw)
In-Reply-To: <ZztHK7WTZLu2V8bD@bfoster>
On Mon, Nov 18, 2024 at 08:54:51AM -0500, Brian Foster wrote:
> I actually think it's easier for you to just fix it up according to your
> needs rather than spin around on the list on it, since I'm not totally
> clear on what the goal is here anyways.
>
> Not sure if you saw my comment here [1], but my goal is to eventually
> remove this code anyways in favor of something that supports more of a
> sparse folio iteration. Whether it gets removed first or reworked in the
> meantime as part of broader cleanups isn't such a big deal. I just want
> to point that out so it's clear it's not worth trying too hard to
> beautify it.
Sounds good, thanks!
next prev parent reply other threads:[~2024-11-18 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 20:01 [PATCH v4 0/3] iomap: zero range flush fixes Brian Foster
2024-11-15 20:01 ` [PATCH v4 1/3] iomap: reset per-iter state on non-error iter advances Brian Foster
2024-11-15 20:01 ` [PATCH v4 2/3] iomap: lift zeroed mapping handling into iomap_zero_range() Brian Foster
2024-11-18 6:29 ` Christoph Hellwig
2024-11-18 13:54 ` Brian Foster
2024-11-18 14:14 ` Christoph Hellwig [this message]
2024-11-15 20:01 ` [PATCH v4 3/3] iomap: elide flush from partial eof zero range Brian Foster
2024-11-20 8:33 ` [PATCH v4 0/3] iomap: zero range flush fixes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZztLwrkl4Qlbm5Ku@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox