From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 03/10] xfs: keep quota directory inode loaded
Date: Tue, 19 Nov 2024 10:27:01 -0800 [thread overview]
Message-ID: <ZzzYdRva5ZuQvMTu@infradead.org> (raw)
In-Reply-To: <20241119181834.GA9438@frogsfrogsfrogs>
On Tue, Nov 19, 2024 at 10:18:34AM -0800, Darrick J. Wong wrote:
> > The commit log here feels a bit sloppy - it keeps the quotadir inode
> > in memory for the entire life time of the file system, and not just
> > the scrub as the above implicitly would imply to me. Maybe clarify
> > this a bit?
>
> Ok, how about:
>
> "In the same vein as the previous patch, there's no point in the
> metapath scrub setup function doing a lookup on the quota metadir just
> so it can validate that lookups work correctly. Instead, retain the
> quota directory inode in memory for the lifetime of the mount so that we
> can check this meaningfully."
Sounds fine.
next prev parent reply other threads:[~2024-11-19 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 23:01 [PATCHSET] xfs: bug fixes for 6.13 Darrick J. Wong
2024-11-18 23:04 ` [PATCH 01/10] xfs: fix off-by-one error in fsmap's end_daddr usage Darrick J. Wong
2024-11-18 23:05 ` [PATCH 02/10] xfs: metapath scrubber should use the already loaded inodes Darrick J. Wong
2024-11-19 5:44 ` Christoph Hellwig
2024-11-18 23:05 ` [PATCH 03/10] xfs: keep quota directory inode loaded Darrick J. Wong
2024-11-19 5:45 ` Christoph Hellwig
2024-11-19 18:18 ` Darrick J. Wong
2024-11-19 18:27 ` Christoph Hellwig [this message]
2024-11-18 23:05 ` [PATCH 04/10] xfs: return a 64-bit block count from xfs_btree_count_blocks Darrick J. Wong
2024-11-19 5:45 ` Christoph Hellwig
2024-11-18 23:05 ` [PATCH 05/10] xfs: don't drop errno values when we fail to ficlone the entire range Darrick J. Wong
2024-11-19 5:46 ` Christoph Hellwig
2024-11-18 23:06 ` [PATCH 06/10] xfs: separate healthy clearing mask during repair Darrick J. Wong
2024-11-19 5:47 ` Christoph Hellwig
2024-11-18 23:06 ` [PATCH 07/10] xfs: set XFS_SICK_INO_SYMLINK_ZAPPED explicitly when zapping a symlink Darrick J. Wong
2024-11-19 5:47 ` Christoph Hellwig
2024-11-18 23:06 ` [PATCH 08/10] xfs: mark metadir repair tempfiles with IRECOVERY Darrick J. Wong
2024-11-19 5:48 ` Christoph Hellwig
2024-11-18 23:06 ` [PATCH 09/10] xfs: fix null bno_hint handling in xfs_rtallocate_rtg Darrick J. Wong
2024-11-19 5:48 ` Christoph Hellwig
2024-11-18 23:07 ` [PATCH 10/10] xfs: fix error bailout in xfs_rtginode_create Darrick J. Wong
2024-11-19 5:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzzYdRva5ZuQvMTu@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox