From: Damien Le Moal <dlemoal@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org,
Andrey Albershteyn <aalbersh@kernel.org>,
Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Subject: Re: [PATCH v2 0/3] Enable cached zone report
Date: Sat, 20 Dec 2025 11:59:48 +0900 [thread overview]
Message-ID: <a2f5f0ff-6fe8-44c6-813b-ebc162b4f025@kernel.org> (raw)
In-Reply-To: <20251220015404.GB1390736@frogsfrogsfrogs>
On 12/20/25 10:54, Darrick J. Wong wrote:
> On Sat, Dec 20, 2025 at 09:00:10AM +0900, Damien Le Moal wrote:
>> On 12/20/25 08:56, Darrick J. Wong wrote:
>>> On Fri, Dec 19, 2025 at 06:38:07PM +0900, Damien Le Moal wrote:
>>>> Enable cached zone report to speed up mkfs and repair on a zoned block
>>>> device (e.g. an SMR disk). Cached zone report support was introduced in
>>>> the kernel with version 6.19-rc1. This was co-developped with
>>>> Christoph.
>>>
>>> Just out of curiosity, do you see any xfsprogs build problems with
>>> BLK_ZONE_COND_ACTIVE if the kernel headers are from 6.18?
>>
>> Nope, I do not, at least not with my Fedora 6.17.12 headers (which do not have
>> BLK_ZONE_COND_ACTIVE defined). Do you see any problem ?
>
> I see it, but only if I ./tools/libxfs-apply the 6.19-rc libxfs/ changes
> to the xfsprogs codebase first. I came up with an ugly workaround:
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git/commit/?h=libxfs-6.19-sync&id=a448911c20ec0d3482361b2287266abd76d9f979
>
> that sloppily #defines it if it doesn't exist.
I addressed this in the v3 series I just posted. Much cleaner I think with the
common xfrog_report_zones() helper.
I am not used to xfsprogs code style though, so please review !
Cheers.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-12-20 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 9:38 [PATCH v2 0/3] Enable cached zone report Damien Le Moal
2025-12-19 9:38 ` [PATCH v2 1/3] libxfs: define BLKREPORTZONEV2 if the kernel does not provide it Damien Le Moal
2025-12-19 9:38 ` [PATCH v2 2/3] mkfs: use cached report zone Damien Le Moal
2025-12-19 9:38 ` [PATCH v2 3/3] repair: " Damien Le Moal
2025-12-19 23:56 ` [PATCH v2 0/3] Enable cached zone report Darrick J. Wong
2025-12-19 23:59 ` Darrick J. Wong
2025-12-20 0:00 ` Damien Le Moal
2025-12-20 1:54 ` Darrick J. Wong
2025-12-20 2:22 ` Damien Le Moal
2025-12-20 2:59 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f5f0ff-6fe8-44c6-813b-ebc162b4f025@kernel.org \
--to=dlemoal@kernel.org \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox