From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: Sorting blocks in xfs_buf_delwri_submit_buffers() still necessary?
Date: Thu, 14 Oct 2021 09:33:53 +0200 (CEST) [thread overview]
Message-ID: <a3df8f39-c030-f36c-d382-8ef297412b@applied-asynchrony.com> (raw)
In-Reply-To: <20211013205755.GJ2361455@dread.disaster.area>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Thu, 14 Oct 2021, Dave Chinner wrote:
> On Wed, Oct 13, 2021 at 07:13:10PM +0200, Holger Hoffstätte wrote:
>> Hi,
>>
>> Based on what's going on in blk-mq & NVMe land
>
> What's going on in this area that is any different from the past few
> years?
Nothing in particular, just watching Jens pull out all the stops is
interesting, and all sorts of other overheads are peeking out from
under the couch.
>> I though I'd check if XFS still
>> sorts buffers before sending them down the pipe, and sure enough that still
>> happens in xfs_buf.c:xfs_buf_delwri_submit_buffers() (the comparson function
>> is directly above). Before I make a fool of myself and try to remove this,
>> do we still think this is necessary?
>
> Yes, I do.
Ok - I completely forgot about merging adjacent requests, and that
only works if they are somehow sorted. Makes sense.
Thank you for the explanation!
Holger
prev parent reply other threads:[~2021-10-14 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 17:13 Sorting blocks in xfs_buf_delwri_submit_buffers() still necessary? Holger Hoffstätte
2021-10-13 20:57 ` Dave Chinner
2021-10-14 7:33 ` Holger Hoffstätte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3df8f39-c030-f36c-d382-8ef297412b@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).