* [PATCH] mkfs: don't overflow the subopts array
@ 2017-09-27 1:38 Darrick J. Wong
2017-09-27 1:40 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2017-09-27 1:38 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
The new -d cowextsize option overran the subopts array; make it larger.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
mkfs/xfs_mkfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 2acf8bf..7c407b0 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -39,7 +39,7 @@ static int ispow2(unsigned int i);
unsigned int blocksize;
unsigned int sectorsize;
-#define MAX_SUBOPTS 16
+#define MAX_SUBOPTS 17
#define SUBOPT_NEEDS_VAL (-1LL)
#define MAX_CONFLICTS 8
#define LAST_CONFLICT (-1)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mkfs: don't overflow the subopts array
2017-09-27 1:38 [PATCH] mkfs: don't overflow the subopts array Darrick J. Wong
@ 2017-09-27 1:40 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2017-09-27 1:40 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
On 9/26/17 8:38 PM, Darrick J. Wong wrote:
> The new -d cowextsize option overran the subopts array; make it larger.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Sigh, sorry for missing that on review, and build, and build, and another build. :(
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 2acf8bf..7c407b0 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -39,7 +39,7 @@ static int ispow2(unsigned int i);
> unsigned int blocksize;
> unsigned int sectorsize;
>
> -#define MAX_SUBOPTS 16
> +#define MAX_SUBOPTS 17
> #define SUBOPT_NEEDS_VAL (-1LL)
> #define MAX_CONFLICTS 8
> #define LAST_CONFLICT (-1)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-27 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 1:38 [PATCH] mkfs: don't overflow the subopts array Darrick J. Wong
2017-09-27 1:40 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).