From: Christoph Hellwig <hch@infradead.org>
To: Luca Di Maio <luca.dimaio1@gmail.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, dimitri.ledkov@chainguard.dev,
smoser@chainguard.dev, hch@infradead.org
Subject: Re: [PATCH v7 1/2] proto: add ability to populate a filesystem from a directory
Date: Fri, 2 May 2025 00:04:45 -0700 [thread overview]
Message-ID: <aBRujXLgmGn5Ywq7@infradead.org> (raw)
In-Reply-To: <47tgriadcj4a6zfrqhpzf3qgz3qfi5rzed4kofpobkrqkvhihn@4okusqlxnfxp>
On the way back from meetings and long distance travel,
so just chiming in with a few points.
One is that the patch split still doesn't make sense to me. Patch 1 adds
all the infrastructure which remains unused, and then patch 2 trivially
wires it up. Please merge the two.
> > Urk, linear search. Oh well, I guess we can switch to a hashtable if
> > we get complaints about issues.
>
> Yea, if it's a problem I can implement an hashtable, from my local
> testing using larger source directories (1.3mln inodes, ~400k hardlinks)
> the difference was actually just a few seconds (given that most of the
> time is doing i/o)
Please add this to the commit log, it's always good to know about the
trade offs and the data supporting it when later looking at the commit
history.
next prev parent reply other threads:[~2025-05-02 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 13:55 [PATCH v7 0/2] mkfs: add ability to populate filesystem from directory Luca Di Maio
2025-04-26 13:55 ` [PATCH v7 1/2] proto: add ability to populate a filesystem from a directory Luca Di Maio
2025-04-28 17:16 ` Darrick J. Wong
2025-04-29 17:33 ` Luca Di Maio
2025-05-02 7:04 ` Christoph Hellwig [this message]
2025-04-26 13:55 ` [PATCH v7 2/2] mkfs: modify -p flag " Luca Di Maio
2025-04-28 17:23 ` Darrick J. Wong
2025-04-28 17:55 ` Luca Di Maio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBRujXLgmGn5Ywq7@infradead.org \
--to=hch@infradead.org \
--cc=dimitri.ledkov@chainguard.dev \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luca.dimaio1@gmail.com \
--cc=smoser@chainguard.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox