From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Catherine Hoang <catherine.hoang@oracle.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH v5] generic: add a test for atomic writes
Date: Sun, 4 May 2025 22:37:07 -0700 [thread overview]
Message-ID: <aBhOg_jB4DWSz1A4@infradead.org> (raw)
In-Reply-To: <20250502193942.GP25675@frogsfrogsfrogs>
On Fri, May 02, 2025 at 12:39:42PM -0700, Darrick J. Wong wrote:
> Me neither. We can't write 512b blocks to the rt device obviously, but
> I think the whole point of the separate "sector" size is that's the
> maximum size that the fs knows it can write to the device without
> tearing.
The sector size is really the minimum addressable unit.
> Maybe there's a way out of this: the only metadata on the realtime
> volume is the rt superblock, whose size is a full fsblock. Perhaps we
> could set/validate the block size of the rt dev with the fsblock size
> instead?
We still allow subsector dio to the rt device, so this would be a bit
of a sketchy change.
next prev parent reply other threads:[~2025-05-05 5:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 4:23 [PATCH v5] generic: add a test for atomic writes Catherine Hoang
2025-04-15 12:59 ` Ritesh Harjani
2025-04-15 18:44 ` Darrick J. Wong
2025-04-17 20:32 ` Darrick J. Wong
2025-05-02 7:12 ` Christoph Hellwig
2025-05-02 19:39 ` Darrick J. Wong
2025-05-05 5:37 ` Christoph Hellwig [this message]
2025-05-05 14:57 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBhOg_jB4DWSz1A4@infradead.org \
--to=hch@infradead.org \
--cc=catherine.hoang@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox