From: Christoph Hellwig <hch@infradead.org>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
fstests@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, djwong@kernel.org, zlang@kernel.org,
david@fromorbit.com, hch@infradead.org, cem@kernel.org
Subject: Re: [PATCH v5 1/1] xfs: Fail remount with noattr2 on a v5 with v4 enabled
Date: Mon, 12 May 2025 08:36:14 -0700 [thread overview]
Message-ID: <aCIVbuot62pZu9xk@infradead.org> (raw)
In-Reply-To: <e03b24e6194c96deb6f74cd8b5e5d61490d539f6.1747043272.git.nirjhar.roy.lists@gmail.com>
This still looks good.
One nit:
> + /*
> + * Now that mp has been modified according to the remount options,
> + * we do a final option validation with xfs_finish_flags()
> + * just like it is done during mount. We cannot use
> + * xfs_finish_flags()on new_mp as it contains only the user
> + * given options.
This could use slightly better formatting:
/*
* Now that mp has been modified according to the remount options, we
* do a final option validation with xfs_finish_flags() just like it is
* done during mount. We cannot use xfs_finish_flags() on new_mp as it
* contains only the user given options.
*/
next prev parent reply other threads:[~2025-05-12 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 9:57 [PATCH v5 0/1] xfs: Fail remount with noattr2 on a v5 xfs with v4 enabled kernel Nirjhar Roy (IBM)
2025-05-12 9:57 ` [PATCH v5 1/1] xfs: Fail remount with noattr2 on a v5 with v4 enabled Nirjhar Roy (IBM)
2025-05-12 11:10 ` Carlos Maiolino
2025-05-12 12:02 ` Nirjhar Roy (IBM)
2025-05-12 15:36 ` Christoph Hellwig [this message]
2025-05-12 16:29 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCIVbuot62pZu9xk@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).