From: Christoph Hellwig <hch@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: Unused event xfs_growfs_check_rtgeom
Date: Thu, 12 Jun 2025 22:59:47 -0700 [thread overview]
Message-ID: <aEu-U-va9q0QRuX0@infradead.org> (raw)
In-Reply-To: <20250612144608.525860bc@batman.local.home>
On Thu, Jun 12, 2025 at 02:46:08PM -0400, Steven Rostedt wrote:
> On Thu, 12 Jun 2025 10:47:37 -0700
> "Darrick J. Wong" <djwong@kernel.org> wrote:
>
> > On Thu, Jun 12, 2025 at 01:16:51PM -0400, Steven Rostedt wrote:
> > > I also found events: xfs_metadir_link and xfs_metadir_start_link are
> > > defined in fs/xfs/libxfs/xfs_metadir.c in a #ifndef __KERNEL__ section.
> > >
> > > Are these events ever used? Why are they called in !__KERNEL__ code?
> >
> > libxfs is shared with userspace, and xfs_repair uses them to relink old
> > quota files.
> >
>
> Does this userspace use these trace events? If so, I think the events
> need to have an:
They have stubs for them.
next prev parent reply other threads:[~2025-06-13 5:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 17:10 Unused event xfs_growfs_check_rtgeom Steven Rostedt
2025-06-12 17:16 ` Steven Rostedt
2025-06-12 17:47 ` Darrick J. Wong
2025-06-12 18:46 ` Steven Rostedt
2025-06-13 5:59 ` Christoph Hellwig [this message]
2025-06-16 14:50 ` Steven Rostedt
2025-06-12 17:47 ` Darrick J. Wong
2025-06-12 20:58 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEu-U-va9q0QRuX0@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).