From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.g.garry@oracle.com>
Cc: George Hu <integral@archlinux.org>,
Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: replace min & max with clamp() in xfs_max_open_zones()
Date: Mon, 14 Jul 2025 03:59:27 -0700 [thread overview]
Message-ID: <aHTjD6FxJYEu6C6R@infradead.org> (raw)
In-Reply-To: <9ba1a836-c4c9-4e1a-903d-42c8b88b03c4@oracle.com>
On Mon, Jul 14, 2025 at 08:58:59AM +0100, John Garry wrote:
> > @@ -1133,9 +1133,7 @@ xfs_max_open_zones(
> > /*
> > * Cap the max open limit to 1/4 of available space
> > */
>
> Maybe you can keep this comment, but it was pretty much describing the code
> and not explaining the rationale.
Let me send an incremental patch to explain the rational as long as I
can still remember it :)
next prev parent reply other threads:[~2025-07-14 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 14:57 [PATCH] xfs: replace min & max with clamp() in xfs_max_open_zones() George Hu
2025-07-14 5:55 ` Christoph Hellwig
2025-07-14 7:58 ` John Garry
2025-07-14 10:59 ` Christoph Hellwig [this message]
2025-07-15 9:49 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHTjD6FxJYEu6C6R@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=integral@archlinux.org \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).