From: Christoph Hellwig <hch@infradead.org>
To: Tony Battersby <tonyb@cybernetics.com>
Cc: Song Liu <song@kernel.org>, Yu Kuai <yukuai3@huawei.com>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-raid@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iomap: align writeback to RAID stripe boundaries
Date: Wed, 30 Jul 2025 07:14:18 -0700 [thread overview]
Message-ID: <aIoouhMhU7VfxYG-@infradead.org> (raw)
In-Reply-To: <55deda1d-967d-4d68-a9ba-4d5139374a37@cybernetics.com>
On Tue, Jul 29, 2025 at 12:13:42PM -0400, Tony Battersby wrote:
> Improve writeback performance to RAID-4/5/6 by aligning writes to stripe
> boundaries. This relies on io_opt being set to the stripe size (or
> a multiple) when BLK_FEAT_RAID_PARTIAL_STRIPES_EXPENSIVE is set.
You're not aligning anything. You are splitting I/O, which is exactly
what we've been trying to avoid by moving to the immutable bio_vec
model that moves the splitting to the place that needs it.
> Benchmark of sequential writing to a large file on XFS using
> io_uring with 8-disk md-raid6:
> Before: 601.0 MB/s
> After: 614.5 MB/s
> Improvement: +2.3%
Looks like you need to do some work on the bio splitting in RAID.
It would help to Cc the maintainers as the driver is actually
pretty actively worked on these days.
prev parent reply other threads:[~2025-07-30 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 16:13 [PATCH 2/2] iomap: align writeback to RAID stripe boundaries Tony Battersby
2025-07-29 18:38 ` Matthew Wilcox
2025-07-29 19:01 ` Tony Battersby
2025-07-29 19:17 ` Matthew Wilcox
2025-07-29 20:12 ` Tony Battersby
2025-07-30 0:52 ` Dave Chinner
2025-07-30 14:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIoouhMhU7VfxYG-@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=song@kernel.org \
--cc=tonyb@cybernetics.com \
--cc=willy@infradead.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).