From: Christoph Hellwig <hch@infradead.org>
To: lukas@herbolt.com
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mkfs.xfs fix sunit size on 512e and 4kN disks.
Date: Fri, 3 Oct 2025 00:46:45 -0700 [thread overview]
Message-ID: <aN9_ZfFEdDCuSTJW@infradead.org> (raw)
In-Reply-To: <80069d04a7bcbbfbb8daad7191c83fb2@herbolt.com>
On Mon, Sep 29, 2025 at 10:59:24AM +0200, lukas@herbolt.com wrote:
> > You Before/after also contain changes for metadir/zoned, looks like you
> > upgraded to a new xfsprogs for your patch, but not the baseline.
> >
> Yeah it was fedora rawhide, 6.12, did not notice the metadir/zoned.
Np. I just started at it to see what you changed.
> > I don't think just picking the data stripe unit is correct here, given
> > that the log can also be external and on a separate device. Instead
> > we'll need to duplicate the calculation based on ft.log, preferably by
> > factoring it into a helper.
> Hmmm, aren't all the <data|rt|log>.sunit" set by blkid_get_topology()?
Yes.
> So as log is internal lsunit should be equal to dsunit and it can only
> differ if the log is external?
Yes.
> My understanding was the LSU check is there mostly if cli->lsu is set.
> Actually if that's assumption is correct it can be done just like this.
That might be a better idea, and should be done in a prep patch.
next prev parent reply other threads:[~2025-10-03 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 12:38 [PATCH] mkfs.xfs fix sunit size on 512e and 4kN disks Lukas Herbolt
2025-09-29 6:54 ` Christoph Hellwig
2025-09-29 8:59 ` lukas
2025-10-03 7:46 ` Christoph Hellwig [this message]
2025-10-07 7:13 ` [PATCH v2] " Lukas Herbolt
2025-10-08 6:06 ` Christoph Hellwig
2025-10-15 6:52 ` [PATCH] " Donald Douwsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN9_ZfFEdDCuSTJW@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).