From: Christoph Hellwig <hch@infradead.org>
To: Lukas Herbolt <lukas@herbolt.com>
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] mkfs.xfs fix sunit size on 512e and 4kN disks.
Date: Tue, 7 Oct 2025 23:06:07 -0700 [thread overview]
Message-ID: <aOX_TzJIxJWWC63x@infradead.org> (raw)
In-Reply-To: <20251007071259.51015-2-lukas@herbolt.com>
On Tue, Oct 07, 2025 at 09:13:00AM +0200, Lukas Herbolt wrote:
> >> and should be done in a prep patch
> Not sure if I got it right, but sending v2
>
> Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
The changes look good. You'll want to send them out as a proper
Linux-style patch with a commit log explaining the changes in a separate
mail, although it would make sense to turn it into a series with your
other patch. git send-email is neat to automate that.
next prev parent reply other threads:[~2025-10-08 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 12:38 [PATCH] mkfs.xfs fix sunit size on 512e and 4kN disks Lukas Herbolt
2025-09-29 6:54 ` Christoph Hellwig
2025-09-29 8:59 ` lukas
2025-10-03 7:46 ` Christoph Hellwig
2025-10-07 7:13 ` [PATCH v2] " Lukas Herbolt
2025-10-08 6:06 ` Christoph Hellwig [this message]
2025-10-15 6:52 ` [PATCH] " Donald Douwsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOX_TzJIxJWWC63x@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).