From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
dsterba@suse.com, cem@kernel.org, linux-btrfs@vger.kernel.org,
linux-xfs@vger.kernel.org, Chris Mason <clm@fb.com>
Subject: Re: [PATCH 1/2] xfs: handle bio split errors during gc
Date: Mon, 20 Oct 2025 09:05:46 -0600 [thread overview]
Message-ID: <aPZPyme5tYvZc9GR@kbusch-mbp> (raw)
In-Reply-To: <20251020145707.GA31743@lst.de>
On Mon, Oct 20, 2025 at 04:57:07PM +0200, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 08:54:46AM -0600, Keith Busch wrote:
> > > Ugg, how? If that actually happens we're toast, so we should find a
> > > way to ensure it does not happen.
> >
> > You'd have to attempt sending an invalid bvec, like something that can't
> > DMA map because you have a byte aligned offset, or the total size is
> > smaller than the block device's.
> >
> > Not that you're doing anything like that here. This condition should
> > never occur in this path because the bio vectors are all nicely aligned.
> > It's just for completeness to ensure it doesn't go uncaught for every
> > bio split caller.
>
> So this is just from code inspection and you did not actually hit
> such a case?
Correct, no one actually hit such errors. Same is true for the btrfs
patch.
next prev parent reply other threads:[~2025-10-20 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 14:43 [PATCH 1/2] xfs: handle bio split errors during gc Keith Busch
2025-10-20 14:43 ` [PATCH 2/2] btrfs: handle bio split errors for append Keith Busch
2025-10-21 21:03 ` kernel test robot
2025-10-20 14:45 ` [PATCH 1/2] xfs: handle bio split errors during gc Christoph Hellwig
2025-10-20 14:54 ` Keith Busch
2025-10-20 14:57 ` Christoph Hellwig
2025-10-20 15:05 ` Keith Busch [this message]
2025-10-20 15:16 ` Chris Mason
2025-10-21 5:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPZPyme5tYvZc9GR@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=cem@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox