From: Dave Chinner <david@fromorbit.com>
To: Lukas Herbolt <lukas@herbolt.com>
Cc: djwong@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: Remove WARN_ONCE if xfs_uuid_table grows over 2x PAGE_SIZE.
Date: Wed, 22 Oct 2025 09:02:40 +1100 [thread overview]
Message-ID: <aPgDAAfq8opIeSWp@dread.disaster.area> (raw)
In-Reply-To: <20251021141744.1375627-4-lukas@herbolt.com>
On Tue, Oct 21, 2025 at 04:17:45PM +0200, Lukas Herbolt wrote:
> The krealloc prints out warning if allocation is bigger than 2x PAGE_SIZE,
> lets use kvrealloc for the memory allocation.
What warning is that? i.e. it helps to quote the error in the
commit message so that, in future, we know exactly what the warning
we fixed here.
If the warning is from the __GFP_NOFAIL directive for this
allocation, then shouldn't we convert this code not to rely on
__GFP_NOFAIL? xfs_uuid_mount() can already return an error, so if
we get an -ENOMEM for this allocation the error should already be
handled correctly and the -ENOMEM get propagated back out to
userspace correctly....
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-10-21 22:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 14:17 [PATCH 0/2] Add FL_WRITE_ZEROES to XFS, fix krealloc on xfs_uuid_table Lukas Herbolt
2025-10-21 14:17 ` [PATCH] xfs: add FALLOC_FL_WRITE_ZEROES to XFS code base Lukas Herbolt
2025-10-21 15:55 ` Darrick J. Wong
2025-10-22 5:00 ` Christoph Hellwig
2025-10-22 7:13 ` Zhang Yi
2025-10-22 7:15 ` Christoph Hellwig
2025-10-22 7:27 ` Zhang Yi
2025-10-29 17:53 ` [PATCH v3] " Lukas Herbolt
2025-10-29 18:22 ` Darrick J. Wong
2025-10-30 7:27 ` Christoph Hellwig
2025-11-12 21:02 ` [PATCH v4] " Lukas Herbolt
2025-11-13 6:59 ` Christoph Hellwig
2025-11-14 8:55 ` [PATCH v5] " Lukas Herbolt
2025-11-14 8:57 ` Christoph Hellwig
2025-11-14 16:44 ` Darrick J. Wong
2025-11-14 16:45 ` Christoph Hellwig
2025-11-18 9:05 ` lukas
2025-12-15 11:48 ` [PATCH v6] " Lukas Herbolt
2025-12-15 14:28 ` Christoph Hellwig
2025-10-30 7:29 ` [PATCH v3] " Christoph Hellwig
2025-10-21 14:17 ` [PATCH 2/2] xfs: Remove WARN_ONCE if xfs_uuid_table grows over 2x PAGE_SIZE Lukas Herbolt
2025-10-21 15:56 ` Darrick J. Wong
2025-10-21 22:02 ` Dave Chinner [this message]
2025-10-26 17:49 ` lukas
2025-10-22 4:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPgDAAfq8opIeSWp@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox