From: Christoph Hellwig <hch@infradead.org>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
Cc: linux-xfs@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, djwong@kernel.org, bfoster@redhat.com,
david@fromorbit.com, hsiangkao@linux.alibaba.com
Subject: Re: [RFC V3 0/3] xfs: Add support to shrink multiple empty AGs
Date: Wed, 22 Oct 2025 00:17:27 -0700 [thread overview]
Message-ID: <aPiFBxhc34RNgu5h@infradead.org> (raw)
In-Reply-To: <cover.1760640936.git.nirjhar.roy.lists@gmail.com>
On Mon, Oct 20, 2025 at 09:13:41PM +0530, Nirjhar Roy (IBM) wrote:
> This work is based on a previous RFC[1] by Gao Xiang and various ideas
> proposed by Dave Chinner in the RFC[1].
>
> Currently the functionality of shrink is limited to shrinking the last
> AG partially but not beyond that. This patch extends the functionality
> to support shrinking beyond 1 AG. However the AGs that we will be remove
> have to empty in order to prevent any loss of data.
>
> The patch begins with the re-introduction of some of the data
> structures that were removed, some code refactoring and
> finally the patch that implements the multi AG shrink design.
> The final patch has all the details including the definition of the
> terminologies and the overall design.
I'm still missing what the overall plan is here. For "normal" XFS
setups you'll always have inodes that we can't migrate. Do you plan
to use this with inode32 only? Also it would be nice to extent this
to rtgroups, as we are guaranteed to not have non-migratable metadata
there and things will actually just work.
next prev parent reply other threads:[~2025-10-22 7:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 15:43 [RFC V3 0/3] xfs: Add support to shrink multiple empty AGs Nirjhar Roy (IBM)
2025-10-20 15:43 ` [RFC V3 1/3] xfs: Re-introduce xg_active_wq field in struct xfs_group Nirjhar Roy (IBM)
2025-10-20 15:43 ` [RFC V3 2/3] xfs: Refactoring the nagcount and delta calculation Nirjhar Roy (IBM)
2026-02-02 14:15 ` Nirjhar Roy (IBM)
2026-02-02 14:38 ` Christoph Hellwig
2026-02-02 16:50 ` Carlos Maiolino
2026-02-02 16:53 ` Nirjhar Roy (IBM)
2025-10-20 15:43 ` [RFC V3 3/3] xfs: Add support to shrink multiple empty AGs Nirjhar Roy (IBM)
2025-10-22 7:17 ` Christoph Hellwig [this message]
2025-10-22 16:05 ` [RFC V3 0/3] " Darrick J. Wong
2025-10-23 5:40 ` Nirjhar Roy (IBM)
2025-10-23 6:34 ` Christoph Hellwig
2025-11-05 7:56 ` Nirjhar Roy (IBM)
2025-11-05 13:12 ` Christoph Hellwig
2025-11-05 19:13 ` Darrick J. Wong
2025-11-10 7:05 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPiFBxhc34RNgu5h@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox