From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>,
linux-xfs@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, bfoster@redhat.com, david@fromorbit.com,
hsiangkao@linux.alibaba.com
Subject: Re: [RFC V3 0/3] xfs: Add support to shrink multiple empty AGs
Date: Wed, 22 Oct 2025 23:34:59 -0700 [thread overview]
Message-ID: <aPnMk_2YNHLJU5wm@infradead.org> (raw)
In-Reply-To: <20251022160532.GM3356773@frogsfrogsfrogs>
On Wed, Oct 22, 2025 at 09:05:32AM -0700, Darrick J. Wong wrote:
> > I'm still missing what the overall plan is here. For "normal" XFS
> > setups you'll always have inodes that we can't migrate. Do you plan
> > to use this with inode32 only?
>
> ...or resurrect xfs_reno?
That only brings up some vague memories. But anything in userspace
would not be transactional safe anyway.
>
> Data/attr extent migration might not be too hard if we can repurpose
> xfs_zonegc for relocations.
The zonegc code is very heavily dependent on not having to deal with
freespace fragmentation for writes, so I don't think the code is
directly reusable. But the overall idea applies, yes.
> I think moving inodes is going to be very
> very difficult because there's no way to atomically update all the
> parents.
>
> (Not to mention whatever happens when the inumber abruptly changes)
Yes. That's my big issues with all the shrink plans, what are we
going to do about inodes?
next prev parent reply other threads:[~2025-10-23 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 15:43 [RFC V3 0/3] xfs: Add support to shrink multiple empty AGs Nirjhar Roy (IBM)
2025-10-20 15:43 ` [RFC V3 1/3] xfs: Re-introduce xg_active_wq field in struct xfs_group Nirjhar Roy (IBM)
2025-10-20 15:43 ` [RFC V3 2/3] xfs: Refactoring the nagcount and delta calculation Nirjhar Roy (IBM)
2026-02-02 14:15 ` Nirjhar Roy (IBM)
2026-02-02 14:38 ` Christoph Hellwig
2026-02-02 16:50 ` Carlos Maiolino
2026-02-02 16:53 ` Nirjhar Roy (IBM)
2025-10-20 15:43 ` [RFC V3 3/3] xfs: Add support to shrink multiple empty AGs Nirjhar Roy (IBM)
2025-10-22 7:17 ` [RFC V3 0/3] " Christoph Hellwig
2025-10-22 16:05 ` Darrick J. Wong
2025-10-23 5:40 ` Nirjhar Roy (IBM)
2025-10-23 6:34 ` Christoph Hellwig [this message]
2025-11-05 7:56 ` Nirjhar Roy (IBM)
2025-11-05 13:12 ` Christoph Hellwig
2025-11-05 19:13 ` Darrick J. Wong
2025-11-10 7:05 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPnMk_2YNHLJU5wm@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox