From: Christoph Hellwig <hch@infradead.org>
To: cem@kernel.org
Cc: aalbersh@kernel.org, david@fromorbit.com, hubjin657@outlook.com,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] metadump: catch used extent array overflow
Date: Tue, 11 Nov 2025 06:19:50 -0800 [thread overview]
Message-ID: <aRNGBoLES2Re4L5m@infradead.org> (raw)
In-Reply-To: <20251111141139.638844-1-cem@kernel.org>
On Tue, Nov 11, 2025 at 03:10:57PM +0100, cem@kernel.org wrote:
> - int used = nex * sizeof(struct xfs_bmbt_rec);
> + xfs_extnum_t used = nex * sizeof(struct xfs_bmbt_rec);
used really isn't a xfs_extnum_t, so you probably just want to use an
undecored uint64_t.
Otherwise this looks good.
next prev parent reply other threads:[~2025-11-11 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 14:10 [PATCH] metadump: catch used extent array overflow cem
2025-11-11 14:19 ` Christoph Hellwig [this message]
2025-11-11 15:10 ` Carlos Maiolino
2025-11-12 16:36 ` Darrick J. Wong
2025-11-12 16:39 ` Christoph Hellwig
2025-11-13 11:09 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRNGBoLES2Re4L5m@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=hubjin657@outlook.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox