[PATCHSET 1/2] xfsprogs: various bug fixes for 6.18

[PATCHSET 1/2] xfsprogs: various bug fixes for 6.18

[Darrick J. Wong]

Hi all,

This is miscellaneous bugfixes.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

This has been running on the djcloud for months with no problems.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=random-fixes

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=random-fixes

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=random-fixes
---
Commits in this patchset:
 * libxfs: fix build warnings
 * xfs_db: document the rtsb command
 * man2: fix getparents ioctl manpage
---
 libxfs/util.c                   |    4 ++--
 man/man2/ioctl_xfs_getparents.2 |    2 +-
 man/man8/xfs_db.8               |    4 ++++
 3 files changed, 7 insertions(+), 3 deletions(-)

[PATCH 1/3] libxfs: fix build warnings

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

gcc 14.2 with all the warnings turn on complains about missing
prototypes for these two functions:

 util.c:147:1: error: no previous prototype for 'current_fixed_time' [-Werror=missing-prototypes]
   147 | current_fixed_time(
       | ^~~~~~~~~~~~~~~~~~
 util.c:590:1: error: no previous prototype for 'get_deterministic_seed' [-Werror=missing-prototypes]
   590 | get_deterministic_seed(
       | ^~~~~~~~~~~~~~~~~~~~~~

Since they're not used outside of util.c, just make them static.

Fixes: 4a54700b4385bb ("libxfs: support reproducible filesystems using deterministic time/seed")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 libxfs/util.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


diff --git a/libxfs/util.c b/libxfs/util.c
index f6af4531ab4663..334e88cd3fcb55 100644
--- a/libxfs/util.c
+++ b/libxfs/util.c
@@ -143,7 +143,7 @@ xfs_log_calc_unit_res(
  *
  * Returns true on success, fail otherwise.
  */
-bool
+static bool
 current_fixed_time(
 	struct			timespec64 *tv)
 {
@@ -586,7 +586,7 @@ void xfs_inode_mark_sick(struct xfs_inode *ip, unsigned int mask) { }
  *
  * Returns true on success, fail otherwise.
  */
-bool
+static bool
 get_deterministic_seed(
 	uint32_t	*result)
 {

Re: [PATCH 1/3] libxfs: fix build warnings

[Christoph Hellwig]

On Mon, Dec 01, 2025 at 05:27:29PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> gcc 14.2 with all the warnings turn on complains about missing
> prototypes for these two functions:

I would have expected a lot more warnings from that in xfsprogs..

But the change itself looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

[PATCH 2/3] xfs_db: document the rtsb command

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

Document the rtsb command, which positions the debugger at the
superblock for the realtime volume, if there is one.

Found by xfs/514.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 man/man8/xfs_db.8 |    4 ++++
 1 file changed, 4 insertions(+)


diff --git a/man/man8/xfs_db.8 b/man/man8/xfs_db.8
index 1e85aebbb5b27c..ba2a68211ef21f 100644
--- a/man/man8/xfs_db.8
+++ b/man/man8/xfs_db.8
@@ -1310,6 +1310,10 @@ .SH COMMANDS
 
 .B rtconvert rsumlog 21 rsuminfo 809 rsumblock 10 rbmblock
 
+.TP
+.B rtsb
+Set current address to the superblock header at the start of the realtime
+volume.
 .TP
 .BI "sb [" agno ]
 Set current address to SB header in allocation group

Re: [PATCH 2/3] xfs_db: document the rtsb command

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

[PATCH 3/3] man2: fix getparents ioctl manpage

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

Fix a silly typo in the manual page for the GETPARENTS ioctl.

Cc: <linux-xfs@vger.kernel.org> # v6.10.0
Fixes: a24294c252d4a6 ("man: document the XFS_IOC_GETPARENTS ioctl")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 man/man2/ioctl_xfs_getparents.2 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/man/man2/ioctl_xfs_getparents.2 b/man/man2/ioctl_xfs_getparents.2
index 5bb9b96a0c95b1..f739c115ed4ead 100644
--- a/man/man2/ioctl_xfs_getparents.2
+++ b/man/man2/ioctl_xfs_getparents.2
@@ -35,7 +35,7 @@ .SH DESCRIPTION
 	__u64                       gp_buffer;
 };
 
-struct xfs_getparents {
+struct xfs_getparents_by_handle {
 	struct xfs_handle           gph_handle;
 	struct xfs_getparents       gph_request;
 };

Re: [PATCH 3/3] man2: fix getparents ioctl manpage

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>