From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: brauner@kernel.org, djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
syzbot+a2b9a4ed0d61b1efb3f5@syzkaller.appspotmail.com
Subject: Re: [PATCH] iomap: allocate s_dio_done_wq for async reads as well
Date: Tue, 25 Nov 2025 08:45:00 +1100 [thread overview]
Message-ID: <aSTR3GHyAZKdRCqo@dread.disaster.area> (raw)
In-Reply-To: <20251124140013.902853-1-hch@lst.de>
On Mon, Nov 24, 2025 at 03:00:13PM +0100, Christoph Hellwig wrote:
> Since commit 222f2c7c6d14 ("iomap: always run error completions in user
> context"), read error completions are deferred to s_dio_done_wq. This
> means the workqueue also needs to be allocated for async reads.
The change LGTM, so:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
But I can't help but wonder about putting this in the fast path....
i.e. on the first io_uring/AIO DIO read or write, we will need
allocate this work queue. I think that's getting quite common in
applications and utilities these days, so filesystems are
increasingly likely to need this wq.
Maybe we should make this wq init unconditional and move it to fs
superblock initialisation? That would remove this "only needed once
for init" check that is made on every call through the the IO fast
path....
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-11-24 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:00 [PATCH] iomap: allocate s_dio_done_wq for async reads as well Christoph Hellwig
2025-11-24 16:32 ` Darrick J. Wong
2025-11-24 21:45 ` Dave Chinner [this message]
2025-11-25 6:35 ` Christoph Hellwig
2025-11-25 8:23 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSTR3GHyAZKdRCqo@dread.disaster.area \
--to=david@fromorbit.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+a2b9a4ed0d61b1efb3f5@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox