Re: [PATCH v1] xfs: test reproducible builds

Luca Di Maio
2025-12-12T16:56:06Z

On Fri, Dec 12, 2025 at 12:11:46AM -0800, Christoph Hellwig wrote:
> On Fri, Dec 12, 2025 at 09:09:56AM +0100, Luca Di Maio wrote:
> > > > +# Compute hash of the image file
> > > > +_hash_image()
> > > > +{
> > > > + md5sum "$1" | awk '{print $1}'
> > >
> > > md5sum is pretty outdated. But we're using it in all kinds of other
> > > places in xfstests, so I think for now this is the right thing to use
> > > here. Eventually we should switch everything over to a more modern
> > > checksum.
> >
> > Will move to sha256sum
>
> I mean stick to md5sum for now. We should eventually migrate
> all md5sum user over when introducing a new dependency anyway.
> Combine that with proper helpers. If that's something you want
> to do it would be great work, but it should not be requirement
> for this.
>

Sorry read this too late and v2 I've moved to sha256sum
Hopefully it's ok?

L.